[Admin Tool Feature]: Get rid of number validation

[ssandino]

Is there an existing request for this feature?

• I have searched the existing issues

Is your feature request related to a problem? Please describe.

Our system currently restricts input to only Sierra Leonean phone numbers. This was initially implemented to prevent NGOs from entering incorrect numbers (such as those missing prefixes). However, NGOs no longer have access to the admin tool, making this restriction unnecessary. Additionally, this limitation complicates testing since most of our test numbers are not from Sierra Leone, requiring manual changes directly in Firestore.

Describe the solution/feature

Remove the restriction that checks and allows only Sierra Leonean phone numbers. This change will facilitate easier and more efficient testing with diverse phone numbers.

Validation is done here recipients properties

Describe alternatives you've considered

No response

Criteria for Completion

No response

Anything else?

Code of Conduct

• I've read the Code of Conduct and understand my responsibilities as a member of the Social Income community

[micharied]

Hello,
I would like to contribute to this project and looked at this issue as a start. Should there be no validation at all or should there be a validation for the length of the number?
Greetings Micha

[ssandino]

Hi @micharied – great, this is actually a good issue to start with!

The validation is done in RecipientsProperties.ts. Removing the validation would already fulfill the issue's goal.

Your question about adding another validation is totally valid. You can of course add a validation, such as limiting the digits to 15 – this is recommended by the ITU (E.164). The minimum length of a valid international phone number is not straightforward, and as such, not validating this seems to be the best approach.

I've assigned this task to you. Please let us know if you need any help along the way. Also, if you notice any steps that haven't been documented for new contributors in the README, thanks for updating it!

[ssandino]

Great job, @micharied. I close the issue.

The comment of @mkue in the PR #706 I added as new issue #719. However, this change might have some effects on the mobile app and must first be discussed.