refactor(admin): update phone number validation #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@micharied is attempting to deploy a commit to the Social Income Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@micharied, just for your information: @mkue is currently traveling and will review this as soon as possible. In the meantime, please feel free to reach out at [email protected], and we can add you to our Slack channel. |
|
Cool, thank you for your contribution :) This looks good for the moment. But in general, I think we should switch to using a string to store a phone number using the + prefix. The validity of the phone number could then easily be checked with a regex. |
mkue
changed the title
2 tasks
This was referenced Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the number validation so that every country code is allowed, but only numbers with a min. length of 5 and a max length of 15 digits. Moreover, now only integers are allowed because a phone number can't be a decimal number.
Note: I couldn't find any tests for the validation. Should we add some tests?
It's my first open-source contribution, so I am happy about every feedback.
Greetings Micha :)