Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Translations for web form #1025

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Web: Translations for web form #1025

merged 2 commits into from
Jan 25, 2025

Conversation

ssandino
Copy link
Member

@ssandino ssandino commented Jan 25, 2025

..

Summary by CodeRabbit

  • Localization Updates
    • Updated German localization:
      • Changed "gender" translation from "Geschlecht" to "Anrede"
      • Updated "male" translation from "Mann" to "Herr"
    • Updated English localization:
      • Modified gender terms to "Man" and "Woman"
    • Updated French localization:
      • Changed "gender" translation from "Sexe" to "Genre"

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
public ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 11:26am

Copy link

coderabbitai bot commented Jan 25, 2025

📝 Walkthrough

Walkthrough

This pull request updates localization files for German, English, and French, focusing on gender-related terminology translations. The changes involve modifying how gender and related terms are represented across different language files, with subtle shifts in translation that reflect more nuanced linguistic approaches to gender representation.

Changes

File Changes
shared/locales/de/common.json - Changed "gender" from "Geschlecht" to "Anrede"
- Updated "male" from "Mann" to "Herr"
shared/locales/en/common.json - Changed "male" from "Male" to "Man"
- Changed "female" from "Female" to "Woman"
shared/locales/fr/common.json - Changed "gender" from "Sexe" to "Genre"

Possibly related PRs

Suggested reviewers

  • andrashee
  • mkue
  • socialincome-dev

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cfbf9b0 and 26568b2.

📒 Files selected for processing (3)
  • shared/locales/de/common.json (1 hunks)
  • shared/locales/en/common.json (1 hunks)
  • shared/locales/fr/common.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • shared/locales/fr/common.json
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: Test functions
  • GitHub Check: Test website
  • GitHub Check: Test admin
  • GitHub Check: Test shared code
  • GitHub Check: Prettify
  • GitHub Check: Security checks (typescript)
🔇 Additional comments (2)
shared/locales/en/common.json (1)

25-26: Verify impact of gender terminology changes.

The shift from "Male"/"Female" to "Man"/"Woman" changes the focus from biological sex to gender identity. Ensure this aligns with:

  1. Form's intended purpose
  2. Database field expectations
  3. Legal requirements for data collection
shared/locales/de/common.json (1)

23-23: Consider semantic differences between language versions.

The German translation now focuses on formal address ("Anrede"/"Herr") while English uses gender identity terms ("Gender"/"Man"). This creates different contextual meanings:

  • English: Gender identity
  • German: Formal address

Consider aligning the semantic meaning across languages or documenting the intentional difference.

Also applies to: 25-25


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Jan 25, 2025

Visit the preview URL for this PR (updated for commit bbb9d95):

https://si-admin-staging--pr1025-sandino-translation-cs6h6c0e.web.app

(expires Sat, 01 Feb 2025 11:20:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676

@ssandino ssandino merged commit cf48150 into main Jan 25, 2025
18 of 19 checks passed
@ssandino ssandino deleted the sandino/translation-in-form branch January 25, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants