refactor(website): styling cleanups for hero sections #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork". Added German translations and made small design changes for a better look and feel. Deleted contact selection as it had the same content as footer, which followed after section. Added important data in hero section, such as contact email and registration number. Left contact section in the code as it's interlinked with another sections and might be reused later (but fine for me when deleted).
ssandino
requested review from
andrashee,
mkue and
renestalder
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Visit the preview URL for this PR (updated for commit f82906f): https://si-admin-staging--pr660-sandino-adapted-hero-n9c7tw2k.web.app (expires Thu, 07 Dec 2023 11:50:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676 |
…ork". Added German translations and made small design changes for a better look and feel. Deleted contact selection as it had the same content as footer, which followed after section. Added important data in hero section, such as contact email and registration number. Left contact section in the code as it's interlinked with another sections and might be reused later (but fine for me when deleted).
…nto sandino/adapted-hero-sections
mkue
reviewed
Nov 29, 2023
| <Typography size="md" lineHeight="normal"> | ||
| {translator.t('landing-page.registration-duns')} | ||
| </Typography> | ||
| <a href="https://www.dnb.com/duns/what-is-a-DUNS-number.html"> |
There was a problem hiding this comment.
You should always use Link components for links.
| <PopoverTrigger> | ||
| <Badge | ||
| variant="outline" | ||
| className="hover:bg-muted-foreground text-muted-foreground hover:text-secondary-foreground transition-transform duration-300 hover:scale-105" |
There was a problem hiding this comment.
I think it's not so nice to have these configurations here in className. They should go into the Badge component so that it behaves the same every time we use it.
| {translator.t('landing-page.registration-uid')} | ||
| </Typography> | ||
| <a href="https://www.uid.admin.ch/Detail.aspx?uid_id=CHE-289.611.695&lang=en"> | ||
| <Button variant="link" className="m-0 p-0"> |
mkue
changed the title
# Conflicts: # website/src/app/[lang]/[region]/(website)/our-work/(sections)/our-work.tsx
mkue
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mkue it would be OK to also delete the now unused
contact.tsx(or to keep it if you want to reuse it later, i.e. on a specific contact page – not planned yet)