-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(website): merge existing webpages into /legal page #738
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Visit the preview URL for this PR (updated for commit 3dab1b8): https://si-admin-staging--pr738-pranav-merge-into-le-ktavgx9q.web.app (expires Tue, 13 Feb 2024 22:25:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676 |
Nice job @DarkMenacer – I made a commit with amendments to the DE translations, as well minor changes to the EN. I see some translations are not yet linked … but this you know of course. 3 things that I noticed (see image with numbering for context)
I think we are almost there! |
|
@DarkMenacer 1. Good, 2. Good, 3. Good – thanks for these last changes and for switching from draft to normal PR for review? The PR will also be used to finish #712. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Once this PR is merged, we can proceed to delete the outdated legal pages (those not organized under the 'legal' path) and set up some redirects to avoid 404 errors.
Very nice! Looks good to me :) |
No description provided.