chore: return false when peerId is blank (#1113)

* chore: return false when peerId is "" * Add test
sofastack · Jun 25, 2024 · aefb594 · aefb594
1 parent 687446e
commit aefb594
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/jraft-core/src/main/java/com/alipay/sofa/jraft/entity/PeerId.java b/jraft-core/src/main/java/com/alipay/sofa/jraft/entity/PeerId.java
@@ -192,7 +192,7 @@ public String toString() {
      *
      */
     public boolean parse(final String s) {
-        if (StringUtils.isEmpty(s)) {
+        if (StringUtils.isEmpty(s) || StringUtils.isBlank(s)) {
             return false;
         }
 

diff --git a/jraft-core/src/test/java/com/alipay/sofa/jraft/entity/PeerIdTest.java b/jraft-core/src/test/java/com/alipay/sofa/jraft/entity/PeerIdTest.java
@@ -25,6 +25,14 @@
 
 public class PeerIdTest {
 
+    @Test
+    public void testToStringPeerIdFalse() {
+        final PeerId serverId = new PeerId();
+        assertFalse(serverId.parse(null));
+        assertFalse(serverId.parse(""));
+        assertFalse(serverId.parse(" "));
+    }
+
     @Test
     public void testToStringParse() {
         final PeerId peer = new PeerId("192.168.1.1", 8081, 0);