chore: remove redundant code

[caicancai]

Motivation:

    @Before
    public void setup() {
        BallotBoxOptions opts = new BallotBoxOptions();
        this.closureQueue = new ClosureQueueImpl(GROUP_ID);
        opts.setClosureQueue(this.closureQueue);
        opts.setWaiter(this.waiter);
        opts.setLastCommittedIndex(0);
        box = new BallotBox();
        assertTrue(box.init(opts));
    }

The code in before is repeated

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

Summary by CodeRabbit

• Tests
  • Updated the initWithLastCommittedIndex() test method in BallotBoxTest to no longer initialize closureQueue with ClosureQueueImpl(GROUP_ID).

[coderabbitai]

Walkthrough

The primary change in this update involves removing the initialization of closureQueue with ClosureQueueImpl(GROUP_ID) in the initWithLastCommittedIndex() method of the BallotBoxTest class. This adjustment streamlines the initialization process, potentially addressing redundancy or improving test efficiency within the BallotBoxTest.

Changes

File Path	Change Summary
jraft-core/src/test/java/com/alipay/sofa/jraft/core/BallotBoxTest.java	Removed this.closureQueue = new ClosureQueueImpl(GROUP_ID) from initWithLastCommittedIndex() method.

Poem

In the BallotBox, under the test light,
The closureQueue takes flight,
Gone from the method, set to rest,
Simplifying processes, at our quest.

🚀✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b401b94 and 1e2265c.

Files selected for processing (1)

• jraft-core/src/test/java/com/alipay/sofa/jraft/core/BallotBoxTest.java (1 hunks)

Additional comments not posted (2)

jraft-core/src/test/java/com/alipay/sofa/jraft/core/BallotBoxTest.java (2)

Line range hint 34-34: Review the setup method to ensure it adequately prepares closureQueue for all tests.

The setup method initializes closureQueue, which should sufficiently prepare it for use in all test methods, including initWithLastCommittedIndex(). This initialization is crucial for the correct operation of all tests that depend on closureQueue.

---

Line range hint 50-50: Ensure removal of closureQueue initialization does not affect tests negatively.

The removal of this.closureQueue = new ClosureQueueImpl(GROUP_ID); in initWithLastCommittedIndex() simplifies the setup but ensure that it doesn't affect the functionality negatively. This change could potentially impact other tests if they rely on closureQueue being initialized.

[caicancai]

cc @fengjiachun @SteNicholas PATL, thanks

[fengjiachun]

LGTM