fix #1380, create NacosRegistryProviderObserver when init method is executed #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2024 17:11
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1392 +/- ##
=========================================
Coverage 72.02% 72.03%
- Complexity 791 797 +6
=========================================
Files 422 422
Lines 17813 17813
Branches 2769 2769
=========================================
+ Hits 12830 12831 +1
- Misses 3568 3570 +2
+ Partials 1415 1412 -3 ☔ View full report in Codecov by Sentry. |
Lo1nt
reviewed
Jan 19, 2024
registry/registry-nacos/src/main/java/com/alipay/sofa/rpc/registry/nacos/NacosRegistry.java
Outdated
Show resolved
Hide resolved
added 2 commits
February 27, 2024 14:33
Lo1nt
reviewed
Mar 1, 2024
registry/registry-nacos/src/main/java/com/alipay/sofa/rpc/registry/nacos/NacosRegistry.java
Outdated
Show resolved
Hide resolved
Lo1nt
reviewed
Mar 1, 2024
registry/registry-nacos/src/main/java/com/alipay/sofa/rpc/registry/nacos/NacosRegistry.java
Outdated
Show resolved
Hide resolved
added 2 commits
March 1, 2024 17:47
wangchengming666
changed the title
EvenLjj
reviewed
Mar 6, 2024
registry/registry-nacos/src/test/java/com/alipay/sofa/rpc/registry/nacos/NacosRegistryTest.java
Outdated
Show resolved
Hide resolved
registry/registry-nacos/src/main/java/com/alipay/sofa/rpc/registry/nacos/NacosRegistry.java
Outdated
Show resolved
Hide resolved
registry/registry-nacos/src/test/java/com/alipay/sofa/rpc/registry/nacos/NacosRegistryTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1380 修改之前的代码创建NacosRegistryProviderObserver是在subscribe里的，修改之后创建NacosRegistryProviderObserver是在init方法里的，init是有同步锁的。