Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1380, create NacosRegistryProviderObserver when init method is executed #1401

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

wangchengming666
Copy link
Collaborator

@wangchengming666 wangchengming666 commented Mar 12, 2024

related #1380

@sofastack-cla sofastack-cla bot added bug Something isn't working question Further information is requested cla:yes CLA is ok size/M labels Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.02%. Comparing base (df2dcae) to head (8554632).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1401      +/-   ##
============================================
- Coverage     72.02%   72.02%   -0.01%     
  Complexity      791      791              
============================================
  Files           422      422              
  Lines         17813    17813              
  Branches       2769     2769              
============================================
- Hits          12830    12829       -1     
  Misses         3568     3568              
- Partials       1415     1416       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Lo1nt Lo1nt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit ac2a73e into sofastack:master Mar 12, 2024
5 checks passed
@wangchengming666 wangchengming666 deleted the fix_issue_1380 branch March 12, 2024 08:20
wangchengming666 pushed a commit to wangchengming666/sofa-rpc that referenced this pull request Mar 22, 2024
support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

fix

support sofa registry kubernetes

fix KubernetesRegistryHelper

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support k8s registry

support k8s registry

update rpc version to 5.13.0-SNAPSHOT (sofastack#1396)

Co-authored-by: liujianjun.ljj <[email protected]>

optimize UserThreadPoolManager (sofastack#1390)

Co-authored-by: 呈铭 <[email protected]>

fix sofastack#1380, create NacosRegistryProviderObserver when init method is executed  (sofastack#1401)

* fix sofastack#1380

* fix sofastack#1380

---------

Co-authored-by: 呈铭 <[email protected]>

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes
@EvenLjj EvenLjj added this to the 5.13.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok question Further information is requested size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants