Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance log format #1436

Merged
merged 1 commit into from
Aug 16, 2024
Merged

enhance log format #1436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions core/api/src/main/java/com/alipay/sofa/rpc/log/LogCodes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ public static String getLog(String code) {
return CODE_DOES_NOT_EXIST + code;
}
try {
return String.format(LOG, code, LOG_CODES.get(code), LogCodes.NOTE);
return format(code, LOG_CODES.get(code), LogCodes.NOTE);
} catch (Throwable e) {
LOGGER.error(LOG_FORMAT_ERROR + code, e);
}
Expand Down Expand Up @@ -428,7 +428,7 @@ public static String getLog(String code, Object... messages) {
}

try {
return String.format(LOG, code, MessageFormat.format(message, messages), LogCodes.NOTE);
return format(code, MessageFormat.format(message, messages), LogCodes.NOTE);
} catch (Throwable e) {
LOGGER.error(LOG_FORMAT_ERROR + code, e);
}
Expand Down Expand Up @@ -456,4 +456,9 @@ public static String getLiteLog(String codeOrMsg, Object... messages) {
}
return LITE_LOG_FORMAT_ERROR + codeOrMsg;
}

private static String format(String code, String message, String note) {
return "RPC-" + code + ": " + message + " " + note;
}

}
Loading