Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SofaRejectedExecutionHandler for user-customized thread pool #1450

Merged
merged 5 commits into from
Oct 14, 2024
Merged

add SofaRejectedExecutionHandler for user-customized thread pool #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3467886
add SofaRejectedExecutionHandler for user custom thread pool
bohrqiu Oct 3, 2024
577a0fd
add RejectedExecutionHandler test case
bohrqiu Oct 3, 2024
92be78b
Merge branch 'sofastack:master' into master
bohrqiu Oct 8, 2024
d36ab09
format code
bohrqiu Oct 8, 2024
b8c1884
format code
bohrqiu Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/api/src/main/java/com/alipay/sofa/rpc/server/UserThreadPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ protected Executor buildExecutor() {
if (prestartAllCoreThreads) {
threadPoolExecutor.prestartAllCoreThreads();
}
threadPoolExecutor.setRejectedExecutionHandler(new SofaRejectedExecutionHandler());
return threadPoolExecutor;
}

Expand Down
13 changes: 13 additions & 0 deletions core/api/src/test/java/com/alipay/sofa/rpc/config/UserThreadPoolManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,13 @@

import com.alipay.sofa.rpc.server.UserThreadPool;
import com.alipay.sofa.rpc.server.UserVirtualThreadPool;
import com.alipay.sofa.rpc.server.SofaRejectedExecutionHandler;
import org.junit.Assert;
import org.junit.Test;

import java.util.Set;
import java.util.concurrent.Executor;
import java.util.concurrent.RejectedExecutionHandler;
import java.util.concurrent.ThreadPoolExecutor;

public class UserThreadPoolManagerTest {
Expand Down Expand Up @@ -67,6 +70,16 @@ public void userThreadPoolBuildTest() {
Assert.assertNull(result);
}

@Test
public void testRejectedExecutionHandler() {
UserThreadPool userThreadPool = new UserThreadPool();
Executor executorService = userThreadPool.getUserExecutor();
Assert.assertTrue(executorService instanceof ThreadPoolExecutor);
RejectedExecutionHandler rejectedExecutionHandler = ((ThreadPoolExecutor) executorService)
.getRejectedExecutionHandler();
Assert.assertTrue(rejectedExecutionHandler instanceof SofaRejectedExecutionHandler);
}

@Test
public void userThreadPoolCompatibleTest() {
UserThreadPool userThreadPool = new UserThreadPool();
Expand Down
Loading