Skip to content

Commit

Permalink
Improve readability of HEADER_SEARCH_PATHS in podspecs (#6949)
Browse files Browse the repository at this point in the history
## Summary

This PR improves readability of `HEADER_SEARCH_PATHS` value in
RNReanimated.podspec and RNWorklets.podspec by passing all flags as an
array of strings and calling `.join(' ')` at the end.

## Test plan
  • Loading branch information
tomekzaw authored Jan 28, 2025
1 parent 28270c0 commit 1c3639e
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
11 changes: 10 additions & 1 deletion packages/react-native-reanimated/RNReanimated.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,16 @@ Pod::Spec.new do |s|
s.pod_target_xcconfig = {
"USE_HEADERMAP" => "YES",
"DEFINES_MODULE" => "YES",
"HEADER_SEARCH_PATHS" => '"$(PODS_TARGET_SRCROOT)/ReactCommon" "$(PODS_TARGET_SRCROOT)" "$(PODS_ROOT)/RCT-Folly" "$(PODS_ROOT)/boost" "$(PODS_ROOT)/boost-for-react-native" "$(PODS_ROOT)/DoubleConversion" "$(PODS_ROOT)/Headers/Private/React-Core" "$(PODS_ROOT)/Headers/Private/Yoga"',
"HEADER_SEARCH_PATHS" => [
'"$(PODS_TARGET_SRCROOT)/ReactCommon"',
'"$(PODS_TARGET_SRCROOT)"',
'"$(PODS_ROOT)/RCT-Folly"',
'"$(PODS_ROOT)/boost"',
'"$(PODS_ROOT)/boost-for-react-native"',
'"$(PODS_ROOT)/DoubleConversion"',
'"$(PODS_ROOT)/Headers/Private/React-Core"',
'"$(PODS_ROOT)/Headers/Private/Yoga"',
].join(' '),
"FRAMEWORK_SEARCH_PATHS" => '"${PODS_CONFIGURATION_BUILD_DIR}/React-hermes"',
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17",
"GCC_PREPROCESSOR_DEFINITIONS[config=Debug]" => gcc_debug_definitions,
Expand Down
11 changes: 10 additions & 1 deletion packages/react-native-worklets/RNWorklets.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,16 @@ Pod::Spec.new do |s|
s.pod_target_xcconfig = {
"USE_HEADERMAP" => "YES",
"DEFINES_MODULE" => "YES",
"HEADER_SEARCH_PATHS" => '"$(PODS_TARGET_SRCROOT)/ReactCommon" "$(PODS_TARGET_SRCROOT)" "$(PODS_ROOT)/RCT-Folly" "$(PODS_ROOT)/boost" "$(PODS_ROOT)/boost-for-react-native" "$(PODS_ROOT)/DoubleConversion" "$(PODS_ROOT)/Headers/Private/React-Core" "$(PODS_ROOT)/Headers/Private/Yoga"',
"HEADER_SEARCH_PATHS" => [
'"$(PODS_TARGET_SRCROOT)/ReactCommon"',
'"$(PODS_TARGET_SRCROOT)"',
'"$(PODS_ROOT)/RCT-Folly"',
'"$(PODS_ROOT)/boost"',
'"$(PODS_ROOT)/boost-for-react-native"',
'"$(PODS_ROOT)/DoubleConversion"',
'"$(PODS_ROOT)/Headers/Private/React-Core"',
'"$(PODS_ROOT)/Headers/Private/Yoga"',
].join(' '),
"FRAMEWORK_SEARCH_PATHS" => '"${PODS_CONFIGURATION_BUILD_DIR}/React-hermes"',
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17",
}
Expand Down

0 comments on commit 1c3639e

Please sign in to comment.