Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preliminary use of react-native-worklets in reanimated #6807

Merged
merged 11 commits into from
Jan 23, 2025

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Dec 11, 2024

Summary

Adding necessary code to detect if react-native-worklets is available and change the build behavior. At the moment we forcefully make it false since react-native-worklets is a stub.

Test plan

CI

@tjzel tjzel changed the title feat: stub of node module react-native-worklets feat: preliminary use of react-native-worklets in reanimated Dec 11, 2024
@tjzel tjzel requested review from tomekzaw and piaskowyk December 11, 2024 12:25
Base automatically changed from @tjzel/worklets/node-module-stub to main December 12, 2024 14:00
@tjzel tjzel added the Check compatibility Trigger a time-consuming compatibility check action label Dec 12, 2024
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 I've tested it on Fabric/Paper iOS/Android and it seems to work ok.

@tjzel tjzel added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit bb0b860 Jan 23, 2025
42 of 48 checks passed
@tjzel tjzel deleted the @tjzel/worklets/node-module-with-rea-support branch January 23, 2025 09:38
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2025
## Summary

This PR fixes issue introduced in #6807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Check compatibility Trigger a time-consuming compatibility check action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants