Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused REANIMATED_MAJOR_VERSION in build.gradle #6927

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Remove unused REANIMATED_MAJOR_VERSION in build.gradle #6927

merged 2 commits into from
Jan 23, 2025

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented Jan 23, 2025 •
edited by github-actions bot
Loading

Summary

This PR removes unused variable REANIMATED_MAJOR_VERSION and getReanimatedMajorVersion in build.gradle.

Test plan

@tomekzaw tomekzaw requested a review from MatiPl01 January 23, 2025 12:19
MatiPl01
MatiPl01 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@MatiPl01 MatiPl01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomekzaw tomekzaw added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 210098c Jan 23, 2025
10 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/remove-reanimated-major-version branch January 23, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatiPl01 MatiPl01 MatiPl01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomekzaw @MatiPl01