Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hot reload in web-example, improve navigation #6947

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

MatiPl01
Copy link
Member

Summary

This PR:

  • fixes hot reload on web,
  • improves navigation (uses proper screen title, better back button name (adds space between words)),
  • fixes web url to navigation state mapping (proper page is displayed on refresh or when navigating to a screen via url change)

@MatiPl01 MatiPl01 self-assigned this Jan 28, 2025
@MatiPl01 MatiPl01 marked this pull request as ready for review January 28, 2025 11:51
@MatiPl01 MatiPl01 changed the title fix: Hot reload on web, improve navigation fix: Hot reload in web-example, improve navigation Jan 28, 2025
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MatiPl01 MatiPl01 enabled auto-merge January 29, 2025 11:04
@MatiPl01 MatiPl01 added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 5784672 Jan 29, 2025
9 checks passed
@MatiPl01 MatiPl01 deleted the @matipl01/web-and-navigation-improvements branch January 29, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants