feat: Add support for multiple transitionBehavior property settings in CSS transitions #6972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiPl01
changed the title
MatiPl01
commented
Feb 3, 2025
packages/react-native-reanimated/Common/cpp/reanimated/CSS/core/CSSTransition.cpp
Show resolved
Hide resolved
MatiPl01
commented
Feb 3, 2025
packages/react-native-reanimated/Common/cpp/reanimated/CSS/core/CSSTransition.cpp
Show resolved
Hide resolved
MatiPl01
commented
Feb 3, 2025
packages/react-native-reanimated/Common/cpp/reanimated/CSS/core/CSSTransition.cpp
Show resolved
Hide resolved
tomekzaw
approved these changes
Feb 4, 2025
MatiPl01
force-pushed
the
@matipl01/fix-transition-interrupting
branch
from
01e4b2b to
5cb9860
Compare
Base automatically changed from
@matipl01/fix-transition-interrupting
to
main
February 4, 2025 15:44
MatiPl01
force-pushed
the
@matipl01/mutliple-transition-behavior-settings
branch
from
afd9c33 to
e7238d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for multiple
transitionBehaviorproperty values in CSS transitions. Before it allowed passing just a single value'normal'/'allow-discrete'. Now it behaves properly and allows passing multiple values as an array.