Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop benchmarks #951

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Develop benchmarks #951

wants to merge 10 commits into from

Conversation

brzep
Copy link
Collaborator

@brzep brzep commented Feb 5, 2025 •
edited
Loading

PR for issue #937

Develop more benchmark options:

  • resolution
    • presets
    • iteration
    • maximize
  • outputs
    • iteration
    • maximize
  • run without encoder
  • run without decoder
  • add csv export option
  • readable output formatting
  • renamed encoder/decoder_count to output/input_count to be more meaningful

@brzep brzep requested a review from jerzywilczek February 5, 2025 14:46
@brzep brzep self-assigned this Feb 5, 2025
@brzep

This comment was marked as resolved.

Sign in to view
jerzywilczek
jerzywilczek reviewed Feb 5, 2025
View reviewed changes
integration_tests/src/bin/benchmark/args.rs Outdated Show resolved Hide resolved
integration_tests/src/bin/benchmark/args.rs Outdated Show resolved Hide resolved
integration_tests/src/bin/benchmark/args.rs Outdated
pub encoder_preset: EncoderPreset,
pub disable_encoder: bool,

#[arg(long, global = true, required_unless_present("disable_encoder"))]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need global here, as we don't have subcommands.

Also, you can use default_value instead of Option

Copy link
Collaborator Author

@brzep brzep Feb 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think default_value changes much here, it's not used anyway if disable_encoder is present. Talking about defaults, I would highly consider adding default values to all parameters, so you don't need to specify all of them every time what is a bit inconvenient

@brzep brzep marked this pull request as ready for review February 14, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerzywilczek jerzywilczek jerzywilczek left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@brzep brzep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brzep @jerzywilczek