This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ana contributing guide. - Simplified explanations of versioned transactions and Address Lookup Tables (LUTs). - Updated code examples to align with best practices. - Ensured the documentation followed the guidelines from the Solana contributing guide. - Enhance readability
- Update Course Codes
- Integrated the `@solana/web3.js `library's modern practices and utilized `@solana-developer/solana-helpers` where appropriate, including transaction confirmation and generating Solana Explorer links. - Enhanced explanation to increase readability
mikemaccana
suggested changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start but a few things to fix, see comments above and we can get this merged - make sure you pay attention to CONTRIBUTING.md
@darkvallen multiple people have submitted for this but I want to let you know you can easily win this one - you're much closer to having an accepted PR. Just get it in quick! |
Fix some review
Updates Based on the Latest Review: - Revised certain sections for clarity - Added a callout - Fixed typos - Removed the usage of starter code and custom helpers in the lab section, and updated to create files from scratch - Import only the necessary function from `solana/web3.js`
Updated @mikemaccana , let me know if there's any further adjustment |
- Add filenames
Thanks @darkvallen ! You won this one. |
adpthegreat
pushed a commit
to adpthegreat/developer-content
that referenced
this pull request
Oct 23, 2024
* Update the Address Lookup Tables (LUTs) course to comply with the Solana contributing guide. - Simplified explanations of versioned transactions and Address Lookup Tables (LUTs). - Updated code examples to align with best practices. - Ensured the documentation followed the guidelines from the Solana contributing guide. - Enhance readability * Update lookup-tables.md - Update Course Codes * Update code snippets - Integrated the `@solana/web3.js `library's modern practices and utilized `@solana-developer/solana-helpers` where appropriate, including transaction confirmation and generating Solana Explorer links. - Enhanced explanation to increase readability * Update lookup-tables.md Fix some review * Update lookup-tables.md Updates Based on the Latest Review: - Revised certain sections for clarity - Added a callout - Fixed typos - Removed the usage of starter code and custom helpers in the lab section, and updated to create files from scratch - Import only the necessary function from `solana/web3.js` * Update lookup-tables.md - Add filenames
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Update the Address Lookup Tables (LUTs) course to comply with the SoLana contributing guide.
Unboxed PR
Unboxed-Software/solana-versioned-transactions#1