This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
Upgrade @solana/wallet-adapter-react for compatibility with Mobile Wallet Adapter and the Wallet Standard
#268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Wallet Adapter and the Wallet Standard
steveluscher
commented
Oct 22, 2022
| "@solana/wallet-adapter-react": "^0.15.21-rc.4", | ||
| "@solana/wallet-adapter-react-ui": "^0.9.19-rc.4", | ||
| "@solana/wallet-adapter-wallets": "^0.19.4", | ||
| "@solana/web3.js": "^1.58.0", |
There was a problem hiding this comment.
This version of web3.js has done away with tweetnacl, hence the reason for the change to the signature verification elsewhere in this PR.
53 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we upgrade
@solana/wallet-adapter-reactto a version that has the following benefits:You can read much more about the wider effort to upgrade the entire ecosystem of Solana web apps at: anza-xyz/wallet-adapter#604
Test plan
Mobile, with mobile wallet
screen-20221021-215652.mp4
Desktop, with desktop wallets
Screen.Recording.2022-10-21.at.9.55.48.PM.mov