Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete list of pitfalls on Getting Started page #1112

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

thomascorthals
Copy link
Member

The list of pitfalls on the Getting Started page is lagging behind the README. And they take up a lot of space in the README while they are irrelevant for new users and hopefully existing users have upgraded by now. Keeping the "official" list in the full documentation and linking it from the README solves both issues.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ddc6da2) 97.49% compared to head (084fd7a) 97.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1112   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         391      391           
  Lines       10150    10150           
=======================================
  Hits         9896     9896           
  Misses        254      254           
Flag Coverage Δ
unittests 97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkalkbrenner mkalkbrenner merged commit b01dde7 into solariumphp:master Dec 1, 2023
27 checks passed
@thomascorthals thomascorthals deleted the docs branch December 1, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants