PHPUnit 9 → 10 #1144
Open
PHPUnit 9 → 10 #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I broke the codecov integration. Converting to draft for now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1144 +/- ##
==========================================
+ Coverage 97.75% 98.13% +0.38%
==========================================
Files 400 403 +3
Lines 10524 10578 +54
==========================================
+ Hits 10288 10381 +93
+ Misses 236 197 -39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Codecov worked after I let it access my branch. But it reported a drop in coverage. Not entirely sure where that came from, I filled in some unit tests for code that was only indirectly covered and it stopped complaining about that. |
thomascorthals
force-pushed
the
phpunit10
branch
from
fb11b39 to
425562b
Compare
|
The Solr 9 tests fail since Solr 9.8 was released. They will pass when #1146 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes affecting us:
setUpBeforeClass()/tearDownAfterClass()can no longer perform assertions. Tests of correct configuration have been moved to separate test functions.static.