Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP/PoC NH-78295 Decouple settings management #96

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

WIP/PoC NH-78295 Decouple settings management #96

wants to merge 40 commits into from

Commits on May 17, 2024

  1. HasLambdaEnv more public

    @tammy-baylis-swi
    tammy-baylis-swi committed May 17, 2024
    Configuration menu
    Copy the full SHA
    bfffc2f View commit details
    Browse the repository at this point in the history

  2. WIP add UpdateSettingFromFile called by agent ticker

    @tammy-baylis-swi
    tammy-baylis-swi committed May 17, 2024
    Configuration menu
    Copy the full SHA
    55bae2e View commit details
    Browse the repository at this point in the history

  3. Move ticker to Oboe

    @tammy-baylis-swi
    tammy-baylis-swi committed May 17, 2024
    Configuration menu
    Copy the full SHA
    5f6e257 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Add settingLambda to unmarshall settings json

    @tammy-baylis-swi
    tammy-baylis-swi committed May 18, 2024
    Configuration menu
    Copy the full SHA
    67d2f5c View commit details
    Browse the repository at this point in the history

  2. UpdateSettingFromFile uses JSON to merge settings

    @tammy-baylis-swi
    tammy-baylis-swi committed May 18, 2024
    Configuration menu
    Copy the full SHA
    7bd3ab4 View commit details
    Browse the repository at this point in the history

  3. Add newSettingLambdaFromFile

    @tammy-baylis-swi
    tammy-baylis-swi committed May 18, 2024
    Configuration menu
    Copy the full SHA
    fb8c8e3 View commit details
    Browse the repository at this point in the history

  4. UpdateSettingFromFile returns bool for success

    @tammy-baylis-swi
    tammy-baylis-swi committed May 18, 2024
    Configuration menu
    Copy the full SHA
    d9156ff View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Revert "UpdateSettingFromFile returns bool for success" 

    This reverts commit d9156ff.
    @tammy-baylis-swi
    tammy-baylis-swi committed May 21, 2024
    Configuration menu
    Copy the full SHA
    331c73c View commit details
    Browse the repository at this point in the history

  2. UpdateSettingFromFile uses UpdateSetting

    @tammy-baylis-swi
    tammy-baylis-swi committed May 21, 2024
    Configuration menu
    Copy the full SHA
    cd1632d View commit details
    Browse the repository at this point in the history

  3. Revert "HasLambdaEnv more public" 

    This reverts commit bfffc2f.
    @tammy-baylis-swi
    tammy-baylis-swi committed May 21, 2024
    Configuration menu
    Copy the full SHA
    42d2b33 View commit details
    Browse the repository at this point in the history

  4. Mv ArgsToMap to general utils

    @tammy-baylis-swi
    tammy-baylis-swi committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c041b6d View commit details
    Browse the repository at this point in the history

  5. Add FileBasedWatcher

    @tammy-baylis-swi
    tammy-baylis-swi committed May 21, 2024
    Configuration menu
    Copy the full SHA
    cf63ef9 View commit details
    Browse the repository at this point in the history

  6. Fix Watcher ticker start/stop

    @tammy-baylis-swi
    tammy-baylis-swi committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4164796 View commit details
    Browse the repository at this point in the history

  7. Rm debug lines

    @tammy-baylis-swi
    tammy-baylis-swi committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8dccd78 View commit details
    Browse the repository at this point in the history

  8. Rm Fbw init for now

    @tammy-baylis-swi
    tammy-baylis-swi committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8efdc1b View commit details
    Browse the repository at this point in the history

  9. Add tests

    @tammy-baylis-swi
    tammy-baylis-swi committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2c64608 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. More tests

    @tammy-baylis-swi
    tammy-baylis-swi committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ea018e9 View commit details
    Browse the repository at this point in the history

  2. Add comments

    @tammy-baylis-swi
    tammy-baylis-swi committed May 22, 2024
    Configuration menu
    Copy the full SHA
    15f719c View commit details
    Browse the repository at this point in the history

  3. Add errchecks

    @tammy-baylis-swi
    tammy-baylis-swi committed May 22, 2024
    Configuration menu
    Copy the full SHA
    189c022 View commit details
    Browse the repository at this point in the history

  4. Update field int types

    @tammy-baylis-swi
    tammy-baylis-swi committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6cb38cd View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Add FileBasedWatcher settingsCache

    @tammy-baylis-swi
    tammy-baylis-swi committed May 23, 2024
    Configuration menu
    Copy the full SHA
    79eb573 View commit details
    Browse the repository at this point in the history

  2. Add errcheck

    @tammy-baylis-swi
    tammy-baylis-swi committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f0fe14a View commit details
    Browse the repository at this point in the history

  3. Fix FileWatcher cache get/set

    @tammy-baylis-swi
    tammy-baylis-swi committed May 23, 2024
    Configuration menu
    Copy the full SHA
    c2e4599 View commit details
    Browse the repository at this point in the history

  4. Comment out FileWatcher UpdateSetting call

    @tammy-baylis-swi
    tammy-baylis-swi committed May 23, 2024
    Configuration menu
    Copy the full SHA
    837d579 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Watcher cachesize 10kb

    @tammy-baylis-swi
    tammy-baylis-swi committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a2e93a2 View commit details
    Browse the repository at this point in the history

  2. Fix pointer

    @tammy-baylis-swi
    tammy-baylis-swi committed May 24, 2024
    Configuration menu
    Copy the full SHA
    69adc5e View commit details
    Browse the repository at this point in the history

  3. FileBasedWatcher does not cache nor updatesetting

    @tammy-baylis-swi
    tammy-baylis-swi committed May 24, 2024
    Configuration menu
    Copy the full SHA
    c8d5d25 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. WIP Add SettingsManager

    @tammy-baylis-swi
    tammy-baylis-swi committed May 29, 2024
    Configuration menu
    Copy the full SHA
    fca445b View commit details
    Browse the repository at this point in the history

  2. WIP add stubs

    @tammy-baylis-swi
    tammy-baylis-swi committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e65f352 View commit details
    Browse the repository at this point in the history

  3. Fix logging, style

    @tammy-baylis-swi
    tammy-baylis-swi committed May 29, 2024
    Configuration menu
    Copy the full SHA
    eb061c2 View commit details
    Browse the repository at this point in the history

  4. Init SettingsManager with Reporter

    @tammy-baylis-swi
    tammy-baylis-swi committed May 29, 2024
    Configuration menu
    Copy the full SHA
    55ad722 View commit details
    Browse the repository at this point in the history

  5. Update SettingsManager method names and todos

    @tammy-baylis-swi
    tammy-baylis-swi committed May 29, 2024
    Configuration menu
    Copy the full SHA
    6d1d36c View commit details
    Browse the repository at this point in the history

  6. Update grpcReporter stub

    @tammy-baylis-swi
    tammy-baylis-swi committed May 29, 2024
    Configuration menu
    Copy the full SHA
    594d959 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge pull request #91 from solarwinds/NH-78295-settings-from-file 

    NH-78295 Add settings FileBasedWatcher
    @tammy-baylis-swi
    tammy-baylis-swi authored May 30, 2024
    Configuration menu
    Copy the full SHA
    86aec44 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'lambda' into NH-78295-decouple-settings-management

    @tammy-baylis-swi
    tammy-baylis-swi authored May 30, 2024
    Configuration menu
    Copy the full SHA
    23b7008 View commit details
    Browse the repository at this point in the history

  3. Messy Merge branch 'NH-78295-grpcreporter-separate-get-update-setting… 

    …' into NH-78295-decouple-settings-management
    @tammy-baylis-swi
    tammy-baylis-swi committed May 30, 2024
    Configuration menu
    Copy the full SHA
    b1b19a7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into lambda

    @tammy-baylis-swi
    tammy-baylis-swi committed May 30, 2024
    Configuration menu
    Copy the full SHA
    64e612e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'lambda' into NH-78295-decouple-settings-management

    @tammy-baylis-swi
    tammy-baylis-swi committed May 30, 2024
    Configuration menu
    Copy the full SHA
    ad12be4 View commit details
    Browse the repository at this point in the history

  6. Mv SettingManager to oboe

    @tammy-baylis-swi
    tammy-baylis-swi committed May 30, 2024
    Configuration menu
    Copy the full SHA
    7def873 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. WIP + mv SManager back else circular import

    @tammy-baylis-swi
    tammy-baylis-swi committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f236826 View commit details
    Browse the repository at this point in the history