Skip to content

Commit

Permalink
chore: add a meaningful alt text, add missing subtitles on video temp…
Browse files Browse the repository at this point in the history
…late
  • Loading branch information
paulovareiro29 committed Nov 14, 2024
1 parent 410a437 commit a277694
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 7 deletions.
2 changes: 1 addition & 1 deletion packages/docs/src/stories/components/video.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export const VideoElementWithPosterSlot = {
</video>
<img
slot="poster"
alt="A generic placeholder video"
alt="Video highlighting Union Investment's digital transformation through a design system named SOLID that enhances accessibility, sustainability, and efficiency."
class="w-[854px] aspect-video cover"
src="./placeholders/images/architecture.jpg"
/>
Expand Down
4 changes: 2 additions & 2 deletions packages/docs/src/stories/components/video.test.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const videoConstant: ConstantDefinition = {
type: 'slot',
name: 'default',
value:
'<video controls id="video-example" class="w-[854px] aspect-video"><source src="./placeholders/videos/ui-placeholder-video.mp4" type="video/mp4" />Your browser does not support the video tag.</video>'
'<video controls id="video-example" class="w-[854px] aspect-video"><source src="./placeholders/videos/ui-placeholder-video.webm" type="video/webm" />Your browser does not support the video tag.</video>'
};
const imageConstant: ConstantDefinition = {
type: 'slot',
Expand All @@ -25,7 +25,7 @@ const posterConstant: ConstantDefinition = {
type: 'slot',
name: 'poster',
value:
'<img slot="poster" alt="A generic placeholder video" class="w-[854px] aspect-video cover" src="./placeholders/images/architecture.jpg" />'
'<img slot="poster" alt="Video highlighting Union Investment\'s digital transformation through a design system named SOLID that enhances accessibility, sustainability, and efficiency." class="w-[854px] aspect-video cover" src="./placeholders/images/architecture.jpg" />'
};
const iconConstant: ConstantDefinition = {
type: 'slot',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,19 @@ export const VideoWithDescription = {
render: () => html`
<sd-video class="sd-media">
<video controls class="aspect-video">
<source src="./placeholders/videos/ui-placeholder-video.mp4" type="video/mp4" />
<source src="./placeholders/videos/ui-placeholder-video.webm" type="video/webm" />
<track
label="English"
kind="subtitles"
srclang="en"
src="./placeholders/captions/ui-placeholder-video.vtt"
default
/>
Your browser does not support the video tag.
</video>
<img
slot="poster"
alt="A generic placeholder video"
alt="Video highlighting Union Investment's digital transformation through a design system named SOLID that enhances accessibility, sustainability, and efficiency."
class="aspect-video cover"
src="./placeholders/images/architecture.jpg"
/>
Expand All @@ -44,12 +51,19 @@ export const VideoWithCopyright = {
<div class="sd-copyright" style="--copyright:'© Union Investment 2024'">
<sd-video>
<video controls class="aspect-video">
<source src="./placeholders/videos/ui-placeholder-video.mp4" type="video/mp4" />
<source src="./placeholders/videos/ui-placeholder-video.webm" type="video/webm" />
<track
label="English"
kind="subtitles"
srclang="en"
src="./placeholders/captions/ui-placeholder-video.vtt"
default
/>
Your browser does not support the video tag.
</video>
<img
slot="poster"
alt="A generic placeholder video"
alt="Video highlighting Union Investment's digital transformation through a design system named SOLID that enhances accessibility, sustainability, and efficiency."
class="aspect-video cover"
src="./placeholders/images/architecture.jpg"
/>
Expand Down

0 comments on commit a277694

Please sign in to comment.