Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🤔 sd-input help-text margin top needs to be updated #1624

Open
9 tasks
MartaPintoTeixeira opened this issue Nov 7, 2024 · 0 comments
Open
9 tasks
Assignees
Labels
🔧 code needs changes in code 🎨 figma needs changes in Figma

Comments

@MartaPintoTeixeira
Copy link
Contributor

MartaPintoTeixeira commented Nov 7, 2024

Current behavior

no margin between help-text and input
Image

Expected behavior

figma: change it to margin-top 4
code: use the same margin you use for "error messages"

Image

For the invalid sample instead of "Error message" change copy to "Error text" if applies.

Steps to reproduce

Technical Information

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 code needs changes in code 🎨 figma needs changes in Figma
Projects
Status: 🛠️ To be pre-refined
Development

No branches or pull requests

2 participants