-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 make validation more accessible in all form elements #1619
Conversation
🚀 Storybook has been deployed for branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vahid1919 the issues mentions a problem about missing labels on icon only templates. Did you check that (as I am missing changes on this topic)?
I also would like to clarify in the daily, if someone remembers what exactly we wanted to accomplish with the mentioned note/caution hint in the ticket. I second that I don't see a problem with the changes in any other component but we added it for some reason...;)
@solid-design-system/core-development I have addressed the recommendations regarding reporting errors on screen readers. I managed to get error messages to be communicated in almost all form elements except sd-radio-group (does not work on Chrome but works fine on Safari -- both tested with VoiceOver). I found some forum discussions regarding what to do in case of screen-reader differences while testing: https://club.ministryoftesting.com/t/why-do-screen-readers-behave-so-differently-from-one-another/69298 How would you suggest we handle these differences right now? @mariohamann @smfonseca @karlbaumhauer PS: I tried some "hacks" using aria-labelledby that allow screen reader error reporting in Chrome, but those cause duplicate readings on Safari. |
Apparently there seems to be an issue with how |
VoiceOver issues for |
Description:
Closes #1483
@solid-design-system/core-development There is a disclaimer that changes made here will affect all other form-related components. In code, the fieldset element is defined inside sd-radio-group. I do not see how it has an effect on the other components since the only relation to the formController is referencing the id to link the labels.
Please let me know, if I am incorrect here.
Definition of Reviewable: