-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve sd-textarea a11y [skip chromatic] #1642
base: main
Are you sure you want to change the base?
Conversation
🚀 Storybook has been deployed for branch |
Some fields are invalid even when not touched, e.g. required or min-length fields are invalid when not touched, since it is empty, but in this cases the aria-invalid should not show, since the user might still be working to fill in the field. Now |
c6482f7
The previous change broke the tests I had done, just pushed a change to fix the tests... |
the margin between the help-text and the text area and the margin between the error message and the text area is not consistent. will create a ticket to solve this issue in both figma and dev |
Description:
Closes #1492
Goals:
aria-invalid
attribute on textarea when the field is invalid.invalid-message
onaria-describedby
Definition of Reviewable: