Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve sd-textarea a11y [skip chromatic] #1642

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

paulovareiro29
Copy link
Contributor

@paulovareiro29 paulovareiro29 commented Nov 13, 2024

Description:

Closes #1492

Goals:

  • Implement aria-invalid attribute on textarea when the field is invalid.
  • Implement invalid-message on aria-describedby

Definition of Reviewable:

  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

Copy link

github-actions bot commented Nov 13, 2024

🚀 Storybook has been deployed for branch fix_improve-sd-textarea-a11y

@smfonseca smfonseca removed their assignment Nov 14, 2024
@paulovareiro29
Copy link
Contributor Author

Some fields are invalid even when not touched, e.g. required or min-length fields are invalid when not touched, since it is empty, but in this cases the aria-invalid should not show, since the user might still be working to fill in the field.

Now aria-invalid="true" only shows when the field in is also a visual invalid state. This is controlled by showInvalidStyle attribute.

Vahid1919
Vahid1919 previously approved these changes Nov 14, 2024
@Vahid1919 Vahid1919 removed their assignment Nov 14, 2024
smfonseca
smfonseca previously approved these changes Nov 14, 2024
@smfonseca smfonseca removed their assignment Nov 14, 2024
karlbaumhauer
karlbaumhauer previously approved these changes Nov 14, 2024
@karlbaumhauer karlbaumhauer removed their assignment Nov 14, 2024
@paulovareiro29
Copy link
Contributor Author

The previous change broke the tests I had done, just pushed a change to fix the tests...
It is rather annoying that the tests quality gate is always falling.

@MartaPintoTeixeira
Copy link
Contributor

the margin between the help-text and the text area and the margin between the error message and the text area is not consistent. will create a ticket to solve this issue in both figma and dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

feat[dev]: ✨ implement A11y improvements to sd-textarea
9 participants