feat: ✨sd-carousel #324
Merged
feat: ✨sd-carousel #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
9 tasks
11 tasks
mariohamann
requested changes
Oct 4, 2023
packages/components/src/components/carousel/carousel.stories.ts
Outdated
Show resolved
Hide resolved
mariohamann
approved these changes
Oct 4, 2023
yoezlem
approved these changes
Oct 4, 2023
karlbaumhauer
requested changes
Oct 4, 2023
| @@ -137,6 +137,28 @@ export const SlidesPerPage = { | |||
| } | |||
| }; | |||
|
|
|||
| /** | |||
| * Use `slides-per-move` to set how many slides the carousel advances when scrolling. Useful when specifying a `slides-per-page` | |||
There was a problem hiding this comment.
what happens when slides-per-page is set to 1 and slides-per-move is set to 2? maybe you can explain the combination a bit more detailed in terms of what to expect => makes it easier to test.
There was a problem hiding this comment.
@karlbaumhauer I added some explanation there, but I thought it was better to show how it works so I expanded on it's story to show that specific example.
Merge branch 'main' into feat/sd-carousel
|
@karlbaumhauer @mariohamann |
Merge branch 'main' into feat/sd-carousel
karlbaumhauer
approved these changes
Oct 6, 2023
|
@Vahid1919 pls change the version in the docs as we already are at v1.17.0 and the sd-carousel will be stable at v1.18.0 afterwards. |
mariohamann
approved these changes
Oct 10, 2023
karlbaumhauer
pushed a commit
that referenced
this pull request
Oct 10, 2023
# [@solid-design-system/components-v1.18.0](components/1.17.0...components/1.18.0) (2023-10-10) ### Features * ✨sd-carousel ([#324](#324)) ([d1a8d0e](d1a8d0e))
yoezlem
pushed a commit
that referenced
this pull request
Oct 25, 2023
yoezlem
pushed a commit
that referenced
this pull request
Oct 25, 2023
# [@solid-design-system/components-v1.18.0](components/1.17.0...components/1.18.0) (2023-10-10) ### Features * ✨sd-carousel ([#324](#324)) ([d1a8d0e](d1a8d0e))
yoezlem
added
the
CL-migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR includes the work for sd-carousel as well as sd-carousel item.
Related to #239
Definition of Reviewable:
PR notes: Irrelevant elements should be removed.