fix: 🐛 prevent rewrite of inset property when border variant was selected in sd-teaser #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azraefendic
requested review from
MarcMatthiae,
mariohamann,
karlbaumhauer,
Vahid1919 and
yoezlem
Vahid1919
approved these changes
Sep 21, 2023
mariohamann
approved these changes
Sep 22, 2023
yoezlem
pushed a commit
that referenced
this pull request
Oct 9, 2023
…cted in sd-teaser (#422) ## Description: Fixed a bug in sd-teaser to prevent rewrite of inset property when changing variants and added a corresponding test for it. Closes #362 ## Definition of Reviewable: *PR notes: Irrelevant elements should be removed.* - [x] relevant tickets are linked - [x] PR is assigned to project board
yoezlem
pushed a commit
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixed a bug in sd-teaser to prevent rewrite of inset property when changing variants and added a corresponding test for it. Closes #362
Definition of Reviewable:
PR notes: Irrelevant elements should be removed.