Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: πŸ“š housekeeping – align slots #443

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Conversation

Vahid1919
Copy link
Contributor

Description:

Replaces all instances of slot-comp in our repository and added a bullet point explaining usage of slots . Closes #359

Definition of Reviewable:

PR notes: Irrelevant elements should be removed.

  • Documentation is created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked
  • PR is assigned to project board

@Vahid1919 Vahid1919 added this to the 1st Solid Release milestone Oct 4, 2023
@Vahid1919 Vahid1919 requested a review from a team October 4, 2023 11:18
@Vahid1919 Vahid1919 linked an issue Oct 4, 2023 that may be closed by this pull request
10 tasks
@Vahid1919 Vahid1919 changed the title docs: πŸ“š housekeeping – align slots chore: πŸ“š housekeeping – align slots Oct 4, 2023
@Vahid1919 Vahid1919 changed the title chore: πŸ“š housekeeping – align slots docs: πŸ“š housekeeping – align slots Oct 4, 2023
@karlbaumhauer karlbaumhauer removed their assignment Oct 4, 2023
@mariohamann
Copy link
Contributor

Please fix this one, too:

https://64469bd84c5ea1ce2dd5d016-mtihaktguv.chromatic.com/?path=/story/components-sd-badge--slots

@mariohamann
Copy link
Contributor

CleanShot 2023-10-04 at 14 18 38@2x

Copy Paste errors here.

In general: I think it makes sense to always write the slot name isntead of this repalce this slot thing everywhere.

@Vahid1919 Vahid1919 changed the title docs: πŸ“š housekeeping – align slots feat: πŸ“š housekeeping – align slots Oct 4, 2023
@Vahid1919 Vahid1919 changed the title feat: πŸ“š housekeeping – align slots docs: πŸ“š housekeeping – align slots Oct 4, 2023
@Vahid1919
Copy link
Contributor Author

Vahid1919 commented Oct 5, 2023

Copy Paste errors here.

In general: I think it makes sense to always write the slot name isntead of this repalce this slot thing everywhere.

@mariohamann I addressed these in the latest commit.

Regarding how we approach them in general, should this be a bigger conversation with the team since Design also uses the "Replace this slot" in most components?

@Vahid1919
Copy link
Contributor Author

@van-nguyen-ht Updated the slot component on all the components that used it. Assigning for Review :)

@mariohamann
Copy link
Contributor

Copy Paste errors here.
In general: I think it makes sense to always write the slot name isntead of this repalce this slot thing everywhere.

@mariohamann I addressed these in the latest commit.

Regarding how we approach them in general, should this be a bigger conversation with the team since Design also uses the "Replace this slot" in most components?

Yeah, makes sense. Personally I would like to have a clean state at least in development and then we could have a look, if design could catch up. What do you think?

@Vahid1919
Copy link
Contributor Author

Copy Paste errors here.
In general: I think it makes sense to always write the slot name isntead of this repalce this slot thing everywhere.

@mariohamann I addressed these in the latest commit.
Regarding how we approach them in general, should this be a bigger conversation with the team since Design also uses the "Replace this slot" in most components?

Yeah, makes sense. Personally I would like to have a clean state at least in development and then we could have a look, if design could catch up. What do you think?

I guess that's fine as well.

@Vahid1919 Vahid1919 merged commit a9397c1 into main Oct 6, 2023
9 checks passed
@Vahid1919 Vahid1919 deleted the docs/align-slots branch October 6, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

docs: πŸ“š housekeeping – align slots
6 participants