-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: π housekeeping β align slots #443
Conversation
Please fix this one, too: https://64469bd84c5ea1ce2dd5d016-mtihaktguv.chromatic.com/?path=/story/components-sd-badge--slots |
@mariohamann I addressed these in the latest commit. Regarding how we approach them in general, should this be a bigger conversation with the team since Design also uses the "Replace this slot" in most components? |
@van-nguyen-ht Updated the slot component on all the components that used it. Assigning for Review :) |
Yeah, makes sense. Personally I would like to have a clean state at least in development and then we could have a look, if design could catch up. What do you think? |
I guess that's fine as well. |
Description:
Replaces all instances of slot-comp in our repository and added a bullet point explaining usage of slots . Closes #359
Definition of Reviewable:
PR notes: Irrelevant elements should be removed.