Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ update sd-accordion meeting WCAG criteria / design refresh #575

Merged
merged 7 commits into from
Nov 20, 2023
Merged

feat: ✨ update sd-accordion meeting WCAG criteria / design refresh #575

merged 7 commits into from
Nov 20, 2023

Conversation

Vahid1919
Copy link
Contributor

Description:

sd-accordion refresh. Closes #407.

Definition of Reviewable:

  • Stories (features, a11y) are created/updated
  • relevant tickets are linked
  • PR is assigned to project board

@Vahid1919 Vahid1919 requested review from a team November 16, 2023 05:38
@Vahid1919 Vahid1919 linked an issue Nov 16, 2023 that may be closed by this pull request
feat: ✨ update sd-accordion meeting WCAG criteria / design refresh #407
Closed
9 tasks
@karlbaumhauer karlbaumhauer removed their assignment Nov 16, 2023
@abudd1094 abudd1094 removed their assignment Nov 16, 2023
@coraliefeil
Copy link
Contributor

Pls reassign when updated. Thanks!

@coraliefeil coraliefeil assigned abudd1094 and unassigned coraliefeil Nov 16, 2023
@Vahid1919
Copy link
Contributor Author

@coraliefeil Thanks for the review :)

For the background story. You're right, It was implemented like a variant.

Since it is supposed to be a guideline only, I am now wondering if it should be a story at all and if the Figma documentation is enough. Maybe we should just make it a Sample? What do you think?

@coraliefeil
Copy link
Contributor

@coraliefeil Thanks for the review :)

For the background story. You're right, It was implemented like a variant.

Since it is supposed to be a guideline only, I am now wondering if it should be a story at all and if the Figma documentation is enough. Maybe we should just make it a Sample? What do you think?

Yes, that’s a good idea. Could you do that, pls? THX

@yoezlem yoezlem removed their assignment Nov 16, 2023
@yoezlem yoezlem self-requested a review November 16, 2023 12:12
@coraliefeil coraliefeil removed their assignment Nov 16, 2023
@coraliefeil
Copy link
Contributor

Approved. Thank you so much!

@abudd1094 abudd1094 removed their assignment Nov 17, 2023
@Vahid1919
Copy link
Contributor Author

@mariohamann @coraliefeil
I updated the accordion's accent to use -16px of the total height instead of the -8px we discussed. This is double that of the sd-navigation-item, but it is pixel perfect with the design in Figma.

@coraliefeil coraliefeil removed their assignment Nov 20, 2023
@coraliefeil
Copy link
Contributor

Approved. THX

@coraliefeil coraliefeil removed the request for review from a team November 20, 2023 10:07
@Vahid1919 Vahid1919 merged commit 9fdbfcb into main Nov 20, 2023
11 checks passed
@Vahid1919 Vahid1919 deleted the feat/update-sd-accordion branch November 20, 2023 10:22
karlbaumhauer pushed a commit that referenced this pull request Nov 20, 2023
@semantic-release-bot
chore(release/components): 1.28.0 [skip actions]
e9b020c 
# [@solid-design-system/components-v1.28.0](components/1.27.0...components/1.28.0) (2023-11-20)

### Features

* ✨ update sd-accordion meeting WCAG criteria / design refresh ([#575](#575)) ([9fdbfcb](9fdbfcb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoezlem yoezlem yoezlem approved these changes

@karlbaumhauer karlbaumhauer karlbaumhauer approved these changes

@abudd1094 abudd1094 abudd1094 approved these changes

@mariohamann mariohamann mariohamann approved these changes

Assignees

@mariohamann mariohamann

@Vahid1919 Vahid1919

@EllaELSA EllaELSA

Labels
None yet
Projects
Solid Design System Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: ✨ update sd-accordion meeting WCAG criteria / design refresh
7 participants
@Vahid1919 @coraliefeil @mariohamann @abudd1094 @karlbaumhauer @yoezlem @EllaELSA