Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ add sd-container - CSS style #619

Merged
merged 2 commits into from
Dec 5, 2023
Merged

feat: ✨ add sd-container - CSS style #619

merged 2 commits into from
Dec 5, 2023

Conversation

Vahid1919
Copy link
Contributor

Description:

Added sd-container. Closes #271.

Definition of Reviewable:

PR notes: Irrelevant elements should be removed.

  • Documentation is created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked
  • PR is assigned to project board

@Vahid1919 Vahid1919 requested review from a team November 27, 2023 19:29
@Vahid1919 Vahid1919 linked an issue Nov 27, 2023 that may be closed by this pull request
feat: ✨ add sd-container - CSS style #271
Closed
18 tasks
@coraliefeil
Copy link
Contributor

Approved from design side. Thanks a lot!

@coraliefeil coraliefeil removed the request for review from a team November 27, 2023 21:03
@yoezlem
Copy link
Contributor

yoezlem commented Nov 28, 2023

Is it possible to leave the default values selected?
image

karlbaumhauer
karlbaumhauer approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@karlbaumhauer karlbaumhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with version hint before merging

packages/components/src/styles/container/container.declaration.ts Outdated Show resolved Hide resolved
@Vahid1919
Copy link
Contributor Author

Is it possible to leave the default values selected? image

@yoezlem It's not very straightforward since these are styles and not strictly attributes. It might take some time to try to figure out. I noticed the other style stories are similar.

@karlbaumhauer
Copy link
Contributor

Is it possible to leave the default values selected?

@yoezlem It's not very straightforward since these are styles and not strictly attributes. It might take some time to try to figure out. I noticed the other style stories are similar.

@Vahid1919 maybe you can open a ticket to find a way and change it in all style-components at once. I support the request from @yoezlem but dont see this blocking here.

@Vahid1919
Copy link
Contributor Author

@Vahid1919 maybe you can open a ticket to find a way and change it in all style-components at once. I support the request from @yoezlem but dont see this blocking here.

Created ticket here: #625

@karlbaumhauer karlbaumhauer removed their assignment Nov 28, 2023
abudd1094
abudd1094 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@abudd1094 abudd1094 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Busy Vahid!

@abudd1094 abudd1094 removed their assignment Nov 29, 2023
@yoezlem yoezlem removed their assignment Nov 29, 2023
@Vahid1919 Vahid1919 merged commit f8028cc into main Dec 5, 2023
11 checks passed
@Vahid1919 Vahid1919 deleted the feat/add-sd-container branch December 5, 2023 08:09
karlbaumhauer pushed a commit that referenced this pull request Dec 5, 2023
@semantic-release-bot
chore(release/components): 1.30.0 [skip actions]
168b132 
# [@solid-design-system/components-v1.30.0](components/1.29.0...components/1.30.0) (2023-12-05)

### Features

* ✨ add sd-container - CSS style ([#619](#619)) ([f8028cc](f8028cc))
@yoezlem yoezlem added 🔧 code needs changes in code CL-migration All components which need to be migrated from Component Library labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoezlem yoezlem yoezlem approved these changes

@karlbaumhauer karlbaumhauer karlbaumhauer approved these changes

@abudd1094 abudd1094 abudd1094 approved these changes

@azraefendic azraefendic azraefendic approved these changes

Assignees

@azraefendic azraefendic

@mariohamann mariohamann

@Vahid1919 Vahid1919

Labels
CL-migration All components which need to be migrated from Component Library 🔧 code needs changes in code
Projects
Solid Design System Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: ✨ add sd-container - CSS style
9 participants
@Vahid1919 @coraliefeil @yoezlem @karlbaumhauer @azraefendic @abudd1094 @mariohamann @van-nguyen-ht @EllaELSA