Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(enable lockfile) bump pnpm and node for development #2439

Merged
merged 2 commits into from
Mar 1, 2025
Merged

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Mar 1, 2025

This updates the pnpm version to one compatible with the existing lockfile, and hte same as solid-start uses (faster ci, because it can install from lockfile)
This updates node to v22 in ci, which is the current LTS

we need this for reproduction of builds
Without this PR each CI release is made without a lockfile, making ti impossible for us to go back in time and make a build of say version 1.9.4 exactly like it was at the time of release, because we don't have proper information about which nested deps versions were used. This makes e.g. debugging of #2436 a lot harder, because a local build at that commit isn't behaving like the published 1.9.4 distribution.

(this is also a problem on the next branch, where similar changes should be applied)

Copy link

changeset-bot bot commented Mar 1, 2025

⚠️ No Changeset found

Latest commit: 18964cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13598807655

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 85.987%

Totals Coverage Status
Change from base Build 13463926269: 0.8%
Covered Lines: 2328
Relevant Lines: 2639

💛 - Coveralls

@birkskyum birkskyum requested a review from ryansolid March 1, 2025 00:24
@birkskyum birkskyum changed the title bump pnpm and node for development enable lockfile - bump pnpm and node for development Mar 1, 2025
@birkskyum birkskyum changed the title enable lockfile - bump pnpm and node for development ci(enab lockfile) bump pnpm and node for development Mar 1, 2025
@birkskyum birkskyum changed the title ci(enab lockfile) bump pnpm and node for development ci(enable lockfile) bump pnpm and node for development Mar 1, 2025
@ryansolid ryansolid merged commit 41fa6c1 into main Mar 1, 2025
1 check passed
@ryansolid
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants