Add text for the admin product/index image column header

This improves accessibility naming the column that holds images.
solidusio · Jul 19, 2023 · d140b24 · d140b24
1 parent 0550665
commit d140b24
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/admin/app/components/solidus_admin/products/index/component.html.erb b/admin/app/components/solidus_admin/products/index/component.html.erb
@@ -10,7 +10,7 @@
     columns: [
       {
         class_name: "w-[72px]",
-        header: "",
+        header: tag.span('aria-label': t('.product_image'), role: 'text'),
         data: -> { image_column(_1) },
       },
       { header: :name, data: -> { name_column(_1) } },

diff --git a/admin/app/components/solidus_admin/products/index/component.yml b/admin/app/components/solidus_admin/products/index/component.yml
@@ -1,4 +1,5 @@
 en:
+  product_image: 'Image'
   status:
     available: 'Available'
     discontinued: 'Discontinued'

diff --git a/admin/app/components/solidus_admin/ui/table/component.rb b/admin/app/components/solidus_admin/ui/table/component.rb
@@ -31,9 +31,7 @@ def render_header_cell(cell)
     # Allow component instances as cell content
     cell = cell.render_in(self) if cell.respond_to?(:render_in)
 
-    cell_tag = cell.blank? ? :td : :th
-
-    content_tag(cell_tag, cell, class: %{
+    content_tag(:th, cell, class: %{
       border-b
       border-gray-100
       px-4