-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark themes to the backend and a theme switching support #4999
Conversation
Some additional notes:
|
backend/app/assets/stylesheets/spree/backend/globals/_dark.scss
Outdated
Show resolved
Hide resolved
backend/app/assets/stylesheets/spree/backend/globals/_dark.scss
Outdated
Show resolved
Hide resolved
54504ef
to
ea70e83
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4999 +/- ##
==========================================
- Coverage 91.57% 88.60% -2.98%
==========================================
Files 188 630 +442
Lines 4415 15081 +10666
==========================================
+ Hits 4043 13362 +9319
- Misses 372 1719 +1347 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
de5b55c
to
cff67ff
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cff67ff
to
8abf738
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
8abf738
to
e48e541
Compare
This comment was marked as resolved.
This comment was marked as resolved.
@MassimilianoLattanzio thanks for you contributions here, but I think we are not going to merge this right now. We are in the process of starting a complete redesign of the admin, and adding Dark Mode now would influence design processes and decisions that we don't want to anticipate now. We will keep this on hold and use as a reference when it will be a good time to add this to the new admin. I hope this makes sense fo you as well, and in the meantime thanks again for your great work! |
Sure! No problem at all! Makes sense to me. Hope this can help other people and also for future updates of the admin UI. |
I self assigned this review, so not considering my approval anymore
52ab498
to
709436f
Compare
92bfed4
to
4591402
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌃
In order to avoid having to support changes after the release this is on hold until the new admin UI and dark-mode implementation will be defined (e.g. cookie vs session vs db). |
0aa9e82
to
5925d58
Compare
5925d58
to
850a525
Compare
850a525
to
e31870d
Compare
e31870d
to
9cc19f1
Compare
- Save the user preference alongside the system preference so that when the system switches the UI will follow along. - Use the session to store preferences so that we start the page with the correct theme(s). - Keep the current theme in the select tag up to date at page load and whenever the system changes. Add dark and dimmed theme variants dark: Full black background with no alteration on images. dimmed: Dark gray background with dimmed images, easier on the eyes but less accurate colors. Co-Authored-By: piyushswain <[email protected]> Co-Authored-By: Elia Schito <[email protected]> Co-Authored-By: Massimiliano Lattanzio <[email protected]>
9cc19f1
to
36c1acb
Compare
Summary
Incorporates #5113
Compation SolidusAdmin PR #5511
This PR aims to add a dark theme switcher for the Solidus backend. The theme can be switched using a new select added in the left sidebar, and the choice is saved in local-storage.
This is just an easy way to invert theme colors as suggested by @elia following this StackOverflow example.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: