Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Tweaks for the product listing #5176

Conversation

waiting-for-dev
Copy link
Contributor

@waiting-for-dev waiting-for-dev commented Jun 23, 2023

Summary

Please, see individual commits for details:

Ref. #5174

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev waiting-for-dev requested a review from a team as a code owner June 23, 2023 05:51
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jun 23, 2023
@waiting-for-dev waiting-for-dev self-assigned this Jun 23, 2023
@chrean chrean assigned elia and unassigned waiting-for-dev Jul 10, 2023
@waiting-for-dev
Copy link
Contributor Author

waiting-for-dev commented Jul 12, 2023

We decided to integrate the changes in work that have been done on top of the product listing. "Use a component for columns in tables" will be left out for now.

Keeping open as reference.

@elia elia force-pushed the waiting-for-dev/admin/product-listing-tweaks branch from e4e17d0 to 23ad174 Compare July 13, 2023 09:18
@elia
Copy link
Member

elia commented Jul 13, 2023

I rebased on the updated dev-branch, skipped the column component which didn't apply well to the updated code.

@elia elia removed request for a team, elia and rainerdema July 13, 2023 09:22
@elia elia added the hold On hold for a reason different from a breaking change label Jul 13, 2023
@elia elia mentioned this pull request Jul 17, 2023
3 tasks
@elia elia force-pushed the waiting-for-dev/admin/product-listing-tweaks branch from 23ad174 to 52e7038 Compare July 26, 2023 14:15
@github-actions github-actions bot added changelog:solidus_admin and removed changelog:repository Changes to the repository not within any gem labels Jul 26, 2023
@elia elia force-pushed the waiting-for-dev/admin/product-listing-tweaks branch 2 times, most recently from ab9c21c to 28a061c Compare July 28, 2023 07:46
@elia elia force-pushed the waiting-for-dev/admin/product-listing-tweaks branch 2 times, most recently from 4d431bb to 68fe185 Compare July 31, 2023 14:24
@elia elia force-pushed the waiting-for-dev/admin/product-listing-tweaks branch from 68fe185 to ad5e4ee Compare August 1, 2023 14:13
@rainerdema rainerdema merged commit 1b02916 into solidusio:nebulab/admin Aug 1, 2023
2 checks passed
@rainerdema rainerdema deleted the waiting-for-dev/admin/product-listing-tweaks branch August 1, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_admin hold On hold for a reason different from a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants