-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin] Tweaks for the product listing #5176
Merged
rainerdema
merged 3 commits into
solidusio:nebulab/admin
from
nebulab:waiting-for-dev/admin/product-listing-tweaks
Aug 1, 2023
Merged
[Admin] Tweaks for the product listing #5176
rainerdema
merged 3 commits into
solidusio:nebulab/admin
from
nebulab:waiting-for-dev/admin/product-listing-tweaks
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:repository
Changes to the repository not within any gem
label
Jun 23, 2023
3 tasks
We decided to integrate the changes in work that have been done on top of the product listing. "Use a component for columns in tables" will be left out for now. Keeping open as reference. |
elia
force-pushed
the
waiting-for-dev/admin/product-listing-tweaks
branch
from
July 13, 2023 09:18
e4e17d0
to
23ad174
Compare
I rebased on the updated dev-branch, skipped the column component which didn't apply well to the updated code. |
3 tasks
elia
force-pushed
the
waiting-for-dev/admin/product-listing-tweaks
branch
from
July 26, 2023 14:15
23ad174
to
52e7038
Compare
github-actions
bot
added
changelog:solidus_admin
and removed
changelog:repository
Changes to the repository not within any gem
labels
Jul 26, 2023
elia
force-pushed
the
waiting-for-dev/admin/product-listing-tweaks
branch
2 times, most recently
from
July 28, 2023 07:46
ab9c21c
to
28a061c
Compare
elia
force-pushed
the
waiting-for-dev/admin/product-listing-tweaks
branch
2 times, most recently
from
July 31, 2023 14:24
4d431bb
to
68fe185
Compare
elia
force-pushed
the
waiting-for-dev/admin/product-listing-tweaks
branch
from
August 1, 2023 14:13
68fe185
to
ad5e4ee
Compare
rainerdema
approved these changes
Aug 1, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Please, see individual commits for details:
Use a component for columns in tables(removed, it was a data cell component that didn't fit in the updated code)products/index
component #5245Ref. #5174
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: