Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] add ui/table dummy scopes #5248

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

elia
Copy link
Member

@elia elia commented Jul 13, 2023

Summary

This is preparatory to batch actions that will replace the "scopes" toolbar when activated.

image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Jul 13, 2023
@elia elia requested a review from rainerdema July 13, 2023 15:15
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jul 13, 2023
@elia elia marked this pull request as ready for review July 13, 2023 15:15
@elia elia requested a review from a team as a code owner July 13, 2023 15:15
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🎨

Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

This sets up the container and usage for the scopes/saved-searches
features without delving into it right away.

Having this bar will avoid the page from "jumping" when we'll show the
batch actions toolbar.
@elia elia force-pushed the elia/admin/ui-table-dummy-scopes branch from edef797 to 5dcb2ec Compare July 17, 2023 09:30
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #5248 (5dcb2ec) into nebulab/admin (b4799eb) will decrease coverage by 0.31%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           nebulab/admin    #5248      +/-   ##
=================================================
- Coverage          88.66%   88.35%   -0.31%     
=================================================
  Files                564      592      +28     
  Lines              13903    14415     +512     
=================================================
+ Hits               12327    12737     +410     
- Misses              1576     1678     +102     

see 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia merged commit c96d454 into nebulab/admin Jul 17, 2023
3 of 4 checks passed
@elia elia deleted the elia/admin/ui-table-dummy-scopes branch July 17, 2023 09:44
@elia elia added changelog:solidus_admin and removed changelog:repository Changes to the repository not within any gem labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants