Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the labeler to correctly mark SolidusAdmin issues #5281

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

elia
Copy link
Member

@elia elia commented Jul 25, 2023

Summary

I already added the changelog:solidus_admin label.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Jul 25, 2023
@elia elia requested a review from a team as a code owner July 25, 2023 17:26
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #5281 (a4d2600) into main (df68c0c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5281   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files         563      563           
  Lines       13889    13889           
=======================================
  Hits        12320    12320           
  Misses       1569     1569           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this because it will be needed at some point but, unless I'm missing something, not immediately. In fact we are merging all the PRs against nebulab/admin branch, which won't be part of the changelog.

As I said, I'm ok with it even if it's like this, but this in this case, let's not expect this change to have an immediate effect.

@elia
Copy link
Member Author

elia commented Jul 26, 2023

@kennyadsl if possible I'd like to merge so that's really easy to use the label to select all PRs related to the admin work, even if they won't show up in the next changelog.

@kennyadsl kennyadsl merged commit 834347e into main Jul 26, 2023
6 checks passed
@kennyadsl kennyadsl deleted the elia/solidus-admin-labeler branch July 26, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants