Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecation horizon #5290

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Update deprecation horizon #5290

merged 1 commit into from
Aug 7, 2023

Conversation

kennyadsl
Copy link
Member

Summary

After we released Solidus 4.0, all the new deprecations need to target the next major, so 5.0.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@kennyadsl
Update deprecation horizon
59920d8 
After we released Solidus 4.0, all the new deprecations need
to target the next major, so 5.0.
@kennyadsl kennyadsl added backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 labels Jul 28, 2023
@kennyadsl kennyadsl self-assigned this Jul 28, 2023
@kennyadsl kennyadsl requested a review from a team as a code owner July 28, 2023 13:30
@kennyadsl kennyadsl mentioned this pull request Jul 28, 2023
Merged
4 tasks
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jul 28, 2023
jarednorman
jarednorman approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not awake yet. I misread the title of the PR and thought "We're deprecating Horizon? What's Horizon?" 🤦🏻‍♂️

@waiting-for-dev waiting-for-dev merged commit 7413879 into solidusio:main Aug 7, 2023
6 checks passed
@waiting-for-dev waiting-for-dev deleted the kennyadsl/update-deprecation-horizon branch August 7, 2023 09:26
This was referenced Aug 7, 2023
Merged
Merged
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

💚 All backports created successfully

Status Branch Result
✅ v4.0
✅ v4.1

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

waiting-for-dev added a commit that referenced this pull request Aug 7, 2023
@waiting-for-dev
Merge pull request #5306 from solidusio/backport/v4.0/pr-5290
e34b131 
[v4.0] Merge pull request #5290 from nebulab/kennyadsl/update-deprecation-horizon
@elia elia added changelog:skip Changes that we don't want to be listed in the Changelog and removed changelog:solidus_core Changes to the solidus_core gem labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@adammathys adammathys adammathys approved these changes

Assignees

@kennyadsl kennyadsl

Labels
backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 changelog:skip Changes that we don't want to be listed in the Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kennyadsl @jarednorman @adammathys @elia @waiting-for-dev