-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin] live product listing search (2) #5291
Closed
elia
wants to merge
11
commits into
nebulab/admin
from
elia+rainer/admin/live-product-listing-search
Closed
[Admin] live product listing search (2) #5291
elia
wants to merge
11
commits into
nebulab/admin
from
elia+rainer/admin/live-product-listing-search
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a new product_search_key configuration option to customize product search attribute in the admin interface. It defaults to `:name_or_variants_including_master_sku_cont`, enabling search by product name or product variants sku.
Update the products controller's index action to prepare parameters needed for the search bar in the products list. The `product_params` method now includes a search_key derived from the `SolidusAdmin::Config[:product_search_key]`. Leveraged Ransack's functionality for building search queries which will be used for querying products.
- Enhance the `ui/table` component by incorporating a `base_search_url` attribute that will be used in the search bar. - Prepare the pagination links to manage search query parameters.
In this commit, we introduce a search bar into the `ui/table` component. The implementation leverages the Ransack gem for searching within the table data. With this addition, users can search for specific records from the `ui/table` component.
This enhancement enables live search functionality in the products list table and in general in the `ui/table` component, allowing users to search for products without reloading the page.
elia
force-pushed
the
elia+rainer/admin/live-product-listing-search
branch
from
July 28, 2023 13:58
c29ad15
to
fb073cd
Compare
This was an internal spike, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: