Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] live product listing search (2) #5291

Closed

Conversation

elia
Copy link
Member

@elia elia commented Jul 28, 2023

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

rainerdema and others added 10 commits July 28, 2023 11:40
Implement a new product_search_key configuration option to customize
product search attribute in the admin interface.
It defaults to `:name_or_variants_including_master_sku_cont`, enabling
search by product name or product variants sku.
Update the products controller's index action to prepare parameters needed
for the search bar in the products list.
The `product_params` method now includes a search_key derived from the
`SolidusAdmin::Config[:product_search_key]`.
Leveraged Ransack's functionality for building search queries which
will be used for querying products.
- Enhance the `ui/table` component by incorporating a
`base_search_url` attribute that will be used in the search bar.
- Prepare the pagination links to manage search query parameters.
In this commit, we introduce a search bar into the `ui/table` component.

The implementation leverages the Ransack gem for searching within
the table data.
With this addition, users can search for specific records from the
`ui/table` component.
This enhancement enables live search functionality in the products
list table and in general in the `ui/table` component, allowing users
to search for products without reloading the page.
@elia elia force-pushed the elia+rainer/admin/live-product-listing-search branch from c29ad15 to fb073cd Compare July 28, 2023 13:58
@elia
Copy link
Member Author

elia commented Jul 31, 2023

This was an internal spike, closing.

@elia elia closed this Jul 31, 2023
@elia elia deleted the elia+rainer/admin/live-product-listing-search branch July 31, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants