Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] connect auth helpers to the sidebar #5293

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

elia
Copy link
Member

@elia elia commented Jul 31, 2023

Summary

image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia requested review from rainerdema and the-krg July 31, 2023 15:32
@elia elia requested a review from a team as a code owner July 31, 2023 15:32
@elia elia self-assigned this Jul 31, 2023
@elia elia marked this pull request as draft July 31, 2023 17:29
@elia elia force-pushed the elia/admin/connect-auth-to-sidebar branch from 9ef6134 to b25dde3 Compare August 1, 2023 10:46
@elia elia force-pushed the elia/admin/connect-auth-to-sidebar branch from b25dde3 to ca89b95 Compare August 1, 2023 12:15
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #5293 (64ebbed) into nebulab/admin (1b08fed) will increase coverage by 0.00%.
Report is 11 commits behind head on nebulab/admin.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           nebulab/admin    #5293   +/-   ##
==============================================
  Coverage          88.56%   88.56%           
==============================================
  Files                599      599           
  Lines              14563    14565    +2     
==============================================
+ Hits               12897    12899    +2     
  Misses              1666     1666           
Files Changed Coverage Δ
...nts/solidus_admin/sidebar/account_nav/component.rb 100.00% <100.00%> (ø)
admin/app/controllers/solidus_admin/auth.rb 100.00% <100.00%> (ø)
...n/app/controllers/solidus_admin/base_controller.rb 100.00% <100.00%> (ø)
admin/lib/solidus_admin/configuration.rb 100.00% <100.00%> (ø)
admin/lib/solidus_admin/preview.rb 93.33% <100.00%> (+1.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review August 1, 2023 12:29
As of now we don't need to also allow procs or symbols as the logout
path is generally not dynamic.
@elia elia force-pushed the elia/admin/connect-auth-to-sidebar branch from ca89b95 to 64ebbed Compare August 1, 2023 15:45
@elia elia merged commit c08ab05 into nebulab/admin Aug 1, 2023
4 checks passed
@elia elia deleted the elia/admin/connect-auth-to-sidebar branch August 1, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants