Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Use the current admin user page as the account path #5294

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

elia
Copy link
Member

@elia elia commented Aug 1, 2023

Summary

This let's us remove the dummy page we previously added to show the logout link.

Fixes #5292

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia requested review from rainerdema and the-krg August 1, 2023 10:59
@elia elia requested a review from a team as a code owner August 1, 2023 10:59
@elia elia self-assigned this Aug 1, 2023
@elia elia linked an issue Aug 1, 2023 that may be closed by this pull request
@elia elia force-pushed the elia/admin/account-path-redirect branch from c1ea85a to 10e7b7f Compare August 1, 2023 13:05
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This let's us remove the dummy page we previously added to show the
logout link.
For some reason the core authorization helper is not working.
@elia elia force-pushed the elia/admin/account-path-redirect branch from 10e7b7f to 806a5f9 Compare August 1, 2023 14:03
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #5294 (806a5f9) into nebulab/admin (1b08fed) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           nebulab/admin    #5294      +/-   ##
=================================================
- Coverage          88.56%   88.54%   -0.02%     
=================================================
  Files                599      599              
  Lines              14563    14565       +2     
=================================================
  Hits               12897    12897              
- Misses              1666     1668       +2     
Files Changed Coverage Δ
...p/controllers/solidus_admin/accounts_controller.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rainerdema rainerdema merged commit 93549ae into nebulab/admin Aug 1, 2023
3 of 4 checks passed
@rainerdema rainerdema deleted the elia/admin/account-path-redirect branch August 1, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Admin] Refactor "accounts/show" view into a separate component
2 participants