-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin] Add filter toolbar for enhanced search functionality #5296
Conversation
Codecov Report
@@ Coverage Diff @@
## nebulab/admin #5296 +/- ##
==============================================
Coverage 88.56% 88.57%
==============================================
Files 599 599
Lines 14573 14579 +6
==============================================
+ Hits 12907 12913 +6
Misses 1666 1666
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fd896c7
to
b17fef6
Compare
This alpha-stage version introduces a filter toolbar to the table component. Please note that this is an initial representation of the filter architecture, and it doesn't represent the final version. Specific changes include: - Addition of a 'filters' method in the products index component, which takes a list of filters. - Addition of a 'filters' prop in the table component, which takes the list of filters and renders them in the filter toolbar. The goal of this initial implementation is to provide a similar level of features in the new product index table as the old one, laying the groundwork for future improvements and updates. Co-Authored-By: Elia Schito <[email protected]>
Changes include: - Addition of new filter in `filters` method in the products index component, now includes an additional filter for 'with_discarded' products. Please note that this is a special case of filters in the context of transitioning from the old to the new products index page. This change ensures that the feature set between the old and new product index page remains consistent. Co-Authored-By: Elia Schito <[email protected]>
b17fef6
to
c3e90b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀 🚀
Summary
This PR introduces a temporary filter toolbar.
This addition is necessary due to the transition from the old admin product page, and to maintain continuity of certain features, specifically the 'With Deleted' option.
This filter toolbar will be further updated in the future to accommodate more sophisticated UI/UX.
Here's an example of how you can add a new filter to see only 'promotionable' products:
Spree::Product
model.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: