Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.1] Bump the minimum required Psych version #5327

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

github-actions[bot]
Copy link

Backport

This will backport the following commits from main to v4.1:

Questions ?

Please refer to the Backport tool documentation

@github-actions github-actions bot requested a review from a team as a code owner August 10, 2023 03:22
@waiting-for-dev waiting-for-dev changed the title [v4.1] Merge pull request #5322 from solidusio/elia/psych-version [v4.1] Bump the minimum required Psych version Aug 10, 2023
@waiting-for-dev waiting-for-dev added the changelog:solidus_core Changes to the solidus_core gem label Aug 10, 2023
The existing code already breaks with older versions and this just
reflects the minimum version that works in the gemspec.

Psych v4.0.1 is the one introducing `YAML.safe_dump` which we're using
to store LogEntry serialized details.

Fixes #5320.

(cherry picked from commit 7d150db)
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #5327 (d39040c) into v4.1 (d39040c) will not change coverage.
The diff coverage is n/a.

❗ Current head d39040c differs from pull request most recent head 23d5c9e. Consider uploading reports for the commit 23d5c9e to get more accurate results

@@           Coverage Diff           @@
##             v4.1    #5327   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files         564      564           
  Lines       13893    13893           
=======================================
  Hits        12319    12319           
  Misses       1574     1574           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@waiting-for-dev waiting-for-dev merged commit b13e221 into v4.1 Aug 10, 2023
4 checks passed
@waiting-for-dev waiting-for-dev deleted the backport/v4.1/pr-5322 branch August 10, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants