Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.1] Fix offense after RuboCop 1.56 #5328

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

github-actions[bot]
Copy link

Backport

This will backport the following commits from main to v4.1:

Questions ?

Please refer to the Backport tool documentation

Rubocop 1.56 fixed a false negative for `Style/RedundantReturn` cop.

See rubocop/rubocop#12106

(cherry picked from commit ddba778)
@github-actions github-actions bot requested a review from a team as a code owner August 10, 2023 04:30
@github-actions github-actions bot mentioned this pull request Aug 10, 2023
3 tasks
@waiting-for-dev waiting-for-dev changed the title [v4.1] Merge pull request #5318 from nebulab/waiting-for-dev/fix_offense_after_rubocop_1.56 [v4.1] Fix offense after RuboCop 1.56 Aug 10, 2023
@waiting-for-dev waiting-for-dev added the changelog:solidus_core Changes to the solidus_core gem label Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #5328 (a3886e9) into v4.1 (1f95ba8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v4.1    #5328   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files         564      564           
  Lines       13893    13893           
=======================================
  Hits        12319    12319           
  Misses       1574     1574           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@waiting-for-dev waiting-for-dev merged commit d39040c into v4.1 Aug 10, 2023
4 checks passed
@waiting-for-dev waiting-for-dev deleted the backport/v4.1/pr-5318 branch August 10, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant