[v3.4] Fix error added when resetting order flow on an empty order #5334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
#4369 introduced a regression where when calling `Spree::Order#restart_checkout_flow` on an empty order, an error would be added to the order. That happened when calling `#next` and the validation failed because no line items were present. We restore the previous behavior where we only try going to the `"address"` state if the order has line items. (cherry picked from commit 82c7bdf)
3 tasks
Codecov Report
@@ Coverage Diff @@
## v3.4 #5334 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 580 580
Lines 14741 14741
=======================================
Hits 12772 12772
Misses 1969 1969
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
waiting-for-dev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov3.4:Questions ?
Please refer to the Backport tool documentation