Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn against Deface interference in Changelog for v3.2 #5352

Merged

Conversation

waiting-for-dev
Copy link
Contributor

Summary

See #5349 for details.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev waiting-for-dev requested a review from a team as a code owner August 18, 2023 12:58
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Aug 18, 2023
@waiting-for-dev waiting-for-dev self-assigned this Aug 18, 2023
@waiting-for-dev waiting-for-dev merged commit d095e38 into solidusio:main Aug 21, 2023
2 checks passed
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/v3.2_warn_deface branch August 21, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants