Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for the first rubygems release of SolidusAdmin #5394

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

elia
Copy link
Member

@elia elia commented Sep 26, 2023

Summary

We're going to release solidus_admin as v0.0.x and tags will be namespaced as solidus_admin/0.0.x.
Releases will be handled manually using Bundler's helpers.

Once SolidusAdmin is ready to take over we'll link it to the main solidus version number and will jump directly to v4.x or v5 or whatever the version will be.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia added this to the 4.2 milestone Sep 26, 2023
@elia elia self-assigned this Sep 26, 2023
@elia elia changed the base branch from main to nebulab/admin September 26, 2023 16:01
@github-actions github-actions bot added changelog:solidus Changes to the solidus meta-gem changelog:solidus_admin labels Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #5394 (8695062) into nebulab/admin (689487b) will decrease coverage by 0.04%.
The diff coverage is 20.00%.

❗ Current head 8695062 differs from pull request most recent head 803ae90. Consider uploading reports for the commit 803ae90 to get more accurate results

@@                Coverage Diff                @@
##           nebulab/admin    #5394      +/-   ##
=================================================
- Coverage          88.80%   88.77%   -0.04%     
=================================================
  Files                609      609              
  Lines              14754    14758       +4     
=================================================
- Hits               13103    13101       -2     
- Misses              1651     1657       +6     
Files Coverage Δ
admin/lib/solidus_admin/version.rb 0.00% <0.00%> (-100.00%) ⬇️
...ib/generators/solidus/install/install_generator.rb 49.63% <25.00%> (-0.75%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review September 27, 2023 11:48
@elia elia requested a review from a team as a code owner September 27, 2023 11:48
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:repository Changes to the repository not within any gem labels Sep 28, 2023
@elia elia force-pushed the nebulab/admin branch 2 times, most recently from 8f839e8 to 689487b Compare September 28, 2023 15:36
Backend should not depend on solidus_admin.
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Sep 29, 2023
@elia elia force-pushed the elia/admin/prepare-release branch 3 times, most recently from 803ae90 to a5aecb5 Compare September 29, 2023 10:25
@elia elia changed the title [admin] Prepare for the first rubygems release Prepare for the first rubygems release of SolidusAdmin Sep 29, 2023
@elia elia merged commit 0a42f67 into nebulab/admin Sep 29, 2023
11 of 13 checks passed
@elia elia deleted the elia/admin/prepare-release branch September 29, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_admin changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus Changes to the solidus meta-gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants