-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for the first rubygems release of SolidusAdmin #5394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus
Changes to the solidus meta-gem
changelog:solidus_admin
labels
Sep 26, 2023
Codecov Report
@@ Coverage Diff @@
## nebulab/admin #5394 +/- ##
=================================================
- Coverage 88.80% 88.77% -0.04%
=================================================
Files 609 609
Lines 14754 14758 +4
=================================================
- Hits 13103 13101 -2
- Misses 1651 1657 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
elia
force-pushed
the
elia/admin/prepare-release
branch
from
September 27, 2023 09:46
2b7127c
to
9d66e25
Compare
rainerdema
approved these changes
Sep 27, 2023
github-actions
bot
added
changelog:solidus_core
Changes to the solidus_core gem
changelog:repository
Changes to the repository not within any gem
labels
Sep 28, 2023
elia
force-pushed
the
nebulab/admin
branch
2 times, most recently
from
September 28, 2023 15:36
8f839e8
to
689487b
Compare
This is temporary and will last until we get out of v0.x.
elia
force-pushed
the
elia/admin/prepare-release
branch
from
September 28, 2023 15:37
ef6a1c8
to
9fa1a61
Compare
For now it should stay opt-in.
Backend should not depend on solidus_admin.
elia
force-pushed
the
elia/admin/prepare-release
branch
from
September 29, 2023 07:53
9fa1a61
to
a5aecb5
Compare
github-actions
bot
added
the
changelog:solidus_backend
Changes to the solidus_backend gem
label
Sep 29, 2023
elia
force-pushed
the
elia/admin/prepare-release
branch
3 times, most recently
from
September 29, 2023 10:25
803ae90
to
a5aecb5
Compare
elia
changed the title
[admin] Prepare for the first rubygems release
Prepare for the first rubygems release of SolidusAdmin
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog:repository
Changes to the repository not within any gem
changelog:solidus_admin
changelog:solidus_backend
Changes to the solidus_backend gem
changelog:solidus_core
Changes to the solidus_core gem
changelog:solidus
Changes to the solidus meta-gem
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're going to release solidus_admin as v0.0.x and tags will be namespaced as
solidus_admin/0.0.x
.Releases will be handled manually using Bundler's helpers.
Once SolidusAdmin is ready to take over we'll link it to the main solidus version number and will jump directly to v4.x or v5 or whatever the version will be.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: