Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update backend configuration for solidus v4.2 #5405

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Update backend configuration for solidus v4.2 #5405

merged 1 commit into from
Oct 2, 2023

Conversation

rainerdema
Copy link
Contributor

@rainerdema rainerdema commented Oct 2, 2023 •
edited
Loading

Summary

The backend_configuration.rb file had preferences still pointing to Solidus v4.1.0.a.

This PR updates the references to Solidus v4.2.0 to ensure the correct versioned preferences are loaded.

From v4.2.0:

  • the default theme preference is 'solidus_admin'
  • the updated admin navbar is enabled
  • do not prioritize menu item partials when both a partial and children exist

Below v4.2.0:

  • the theme is 'classic'
  • the old admin navbar is used
  • the system prioritizes menu item partials in the same scenario

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@rainerdema rainerdema added the type:bug Error, flaw or fault label Oct 2, 2023
@rainerdema rainerdema self-assigned this Oct 2, 2023
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Oct 2, 2023
@rainerdema rainerdema force-pushed the rainerd/fix/admin-backend-config-version-updates branch from e43fa44 to a488bd6 Compare October 2, 2023 14:47
@rainerdema
Update version references in backend_configuration.rb for Solidus 4…
ff09c3f 
….2.0

The `backend_configuration.rb` file had preferences still pointing to
`Solidus v4.1.0.a`.

This commit updates the references to `Solidus v4.2` to ensure the correct
versioned preferences are loaded.
@rainerdema rainerdema force-pushed the rainerd/fix/admin-backend-config-version-updates branch from a488bd6 to ff09c3f Compare October 2, 2023 15:04
@rainerdema rainerdema requested a review from elia October 2, 2023 15:54
@rainerdema rainerdema marked this pull request as ready for review October 2, 2023 15:54
@rainerdema rainerdema requested a review from a team as a code owner October 2, 2023 15:54
elia
elia approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thanks!

@elia elia merged commit 41495d2 into solidusio:main Oct 2, 2023
9 checks passed
@elia elia deleted the rainerd/fix/admin-backend-config-version-updates branch October 2, 2023 17:29
@elia elia added the backport-v4.2 Backport this pull-request to v4.2 label Oct 2, 2023
@github-actions github-actions bot mentioned this pull request Oct 2, 2023
Merged
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

💚 All backports created successfully

Status Branch Result
✅ v4.2

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees

@rainerdema rainerdema

Labels
backport-v4.2 Backport this pull-request to v4.2 changelog:solidus_backend Changes to the solidus_backend gem type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rainerdema @elia