Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.4] Add activestorage as dependency #5480

Merged
merged 2 commits into from
Nov 1, 2023
Merged

[v3.4] Add activestorage as dependency #5480

merged 2 commits into from
Nov 1, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 1, 2023

Backport

This will backport the following commits from main to v3.4:

Questions ?

Please refer to the Backport tool documentation

This reverts commit ea0254b.

(cherry picked from commit 9c87e08)
We use ActiveStorage::Current in our BaseControllers
since a3119d5 but
we never depended on it.

For stores never having activestorage as dependency
this was breaking.

(cherry picked from commit d495087)
@github-actions github-actions bot requested a review from a team as a code owner November 1, 2023 16:32
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Nov 1, 2023
@tvdeyen tvdeyen merged commit 03f342b into v3.4 Nov 1, 2023
18 of 19 checks passed
@tvdeyen tvdeyen deleted the backport/v3.4/pr-5479 branch November 1, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants