Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.1] Use ActiveRecord's .find_each instead of .each whenever possible #5484

Merged
merged 2 commits into from
Nov 2, 2023
Merged

[4.1] Use ActiveRecord's .find_each instead of .each whenever possible #5484

merged 2 commits into from
Nov 2, 2023

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 2, 2023

Summary

Backport of #5380 for v4.1

@tvdeyen tvdeyen added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem changelog:repository Changes to the repository not within any gem labels Nov 2, 2023
@tvdeyen tvdeyen requested a review from a team as a code owner November 2, 2023 07:28
@tvdeyen tvdeyen mentioned this pull request Nov 2, 2023
Merged
3 tasks
elia
elia approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍
pending the installer specs, tbh I'm not sure why the rackup executable is causing trouble, maybe there's a -y or -f that we can add to overcome the problem.

@tvdeyen
Copy link
Member Author

tvdeyen commented Nov 2, 2023

pending the installer specs

@elia we would need to backport #5477 to v4.1 (and 4.1, 4.2 and 3.4 tbh), because all those branches test the installation of latest solidus, what does not make any sense

@elia
Copy link
Member

elia commented Nov 2, 2023

@tvdeyen I'm down with backporting it, I think the backport labels will trigger the gh action even after merge 👍

@tvdeyen
Copy link
Member Author

tvdeyen commented Nov 2, 2023

That's good to know. @kennyadsl agree?

@kennyadsl
Copy link
Member

Works for me!

@tvdeyen tvdeyen merged commit 594abef into solidusio:v4.1 Nov 2, 2023
18 of 19 checks passed
@tvdeyen tvdeyen deleted the 4.1-rubocop-update branch November 2, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees
No one assigned
Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvdeyen @elia @kennyadsl